Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@slack/webhook: set min node to 18, prep for major release #1666

Merged
merged 1 commit into from
Oct 4, 2023
Merged

@slack/webhook: set min node to 18, prep for major release #1666

merged 1 commit into from
Oct 4, 2023

Conversation

filmaj
Copy link
Contributor

@filmaj filmaj commented Oct 3, 2023

Update dependencies to latest versions to 18, fix linter and typescript warnings, in prep for a major version release.

Following the same process as for the @slack/logger package (#1650).

@filmaj
@slack/webhook: update dependencies to latest versions, set min node …
1cce8af 
…to 18, fix linter and typescript warnings, in prep for a major version release.
@filmaj filmaj added semver:major pkg:webhook applies to `@slack/webhook` labels Oct 3, 2023
@filmaj filmaj added this to the [email protected] milestone Oct 3, 2023
@filmaj filmaj requested a review from a team October 3, 2023 18:57
@filmaj filmaj self-assigned this Oct 3, 2023
srajiang
srajiang approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@srajiang srajiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@filmaj filmaj merged commit 85c07d9 into main Oct 4, 2023
14 checks passed
@filmaj filmaj deleted the webhook-major branch October 4, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srajiang srajiang srajiang approved these changes

@seratch seratch seratch approved these changes

Assignees

@filmaj filmaj

Labels
pkg:webhook applies to `@slack/webhook` semver:major
Projects
None yet
Milestone
[email protected]
Development

Successfully merging this pull request may close these issues.
3 participants
@filmaj @seratch @srajiang